Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validate argument for non array inputs #5317

Conversation

angrykoala
Copy link
Member

Description

Fixes the issue where valid graphql arguments in @authorization validate would not be properly parsed

Copy link

changeset-bot bot commented Jul 5, 2024

🦋 Changeset detected

Latest commit: f4c41fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@neo4j/graphql Patch
@neo4j/graphql-ogm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Jul 5, 2024

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 39 44 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 49 64 1134
aggregations.NestedAggregation 16544 16544 77 85 2174
aggregations.AggregationWithWhere 11970 11970 49 69 2174
aggregations.AggregationWhereWithinNestedRelationships 22116478 22116478 2268 2404 2008534
aggregations.AggregationWhereWithinNestedConnections 22116478 22116478 2267 2288 2008534
aggregations.NestedCountFromMovieToActors 9701 9701 37 40 2174
aggregations.NestedCountFromActorsToMovie 9928 9928 40 40 2174
aggregations.DeeplyNestedCount 11062184 11062184 3050 3058 2008534
aggregations.InterfacesAggregations 6242 6242 46 54 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 74 86 2080
batch-create.BatchCreate 4200 4200 122 144 600
batch-create.BatchCreateSmall 77 77 53 63 11
connect.createAndConnect 14424 14424 139 195 3003
connections.Connection 14049 14049 61 74 2174
connections.NestedConnection 41068 41068 125 129 4516
create.SimpleMutation 7 7 55 56 1
cypher-directive.TopLevelMutationDirective 1135 1135 26 28 1134
delete.SimpleDelete 19401 19401 198 283 1040
delete.NestedDeleteInUpdate 19165 19165 124 182 2040
2871.NestedRelationshipFilter 23171 23009 56 73 4456
2925.SingleRelationshipFilter 6468 6468 75 59 1040
2925.NestedSingleRelationshipFilter 22891 22891 83 121 2174
2925.SingleRelationshipRequiredFilter 5201 5201 36 43 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 57 64 1040
query.SimpleQuery 3121 3121 20 24 1040
query.SimpleQueryWithRelationship 16129 16129 54 52 2174
query.QueryWhere 9685 9693 38 38 2165
query.SimpleQueryWithNestedWhere 9852 9860 47 60 2165
query.Nested 10095502 10095502 7027 6708 2008534
query.NestedWithFilter 10074351 10074351 6890 6828 2004000
query.OrFilterOnRelationships 42354 42323 146 177 1659
query.OrFilterOnRelationshipsAndNested 36034 36657 191 252 1659
query.QueryWithNestedIn 13232 13358 60 70 1171
query.NestedConnectionWhere 9801 9801 55 63 2174
query.DeeplyNestedConnectionWhere 9798 9866 77 86 2174
query.DeeplyNestedWithRelationshipFilters 18734 18746 146 147 1576
query.NestedWithRelationshipSingleFilters 3865 3865 179 190 1134
query.Fulltext 64 64 32 38 16
query.FulltextWithNestedQuery 558 558 43 48 84
sorting-and-cypher.TopLevelSortWithCypher 14059 14059 40 51 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 14059 14059 61 81 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 14204 14204 59 77 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 14204 14204 96 99 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 14899 14933 105 121 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 14404 14404 130 128 2174
sorting.SortMultipleTypes 3498 3498 83 96 1040
sorting.SortMultipleTypesWithCypherWithCypher 14504 14504 100 125 2174
sorting.SortOnNestedFields 14049 14049 45 59 2174
sorting.SortDeeplyNestedFields 43148 43148 87 93 4516
sorting.ConnectionWithSort 3281 3281 73 82 1040
unions.SimpleUnionQuery 321 321 58 64 35
unions.SimpleUnionQueryWithMissingFields 293 293 54 65 35
unions.NestedUnion 410637 410637 242 262 33033
unions.NestedUnionWithMissingFields 384611 384611 250 248 33033
update.NestedUpdate 16143 16143 106 113 2002

Old Schema Generation: 28.462s
Schema Generation: 29.040s
Old Subgraph Schema Generation: 32.830s
Subgraph Schema Generation: 33.899s

@angrykoala angrykoala force-pushed the 4534-authorization-validate-argument-should-also-handle-a-single-non-array-entry branch from bb11504 to f4c41fe Compare July 5, 2024 13:46
@angrykoala angrykoala merged commit af2e31d into dev Jul 5, 2024
80 checks passed
This was referenced Jul 5, 2024
@angrykoala angrykoala deleted the 4534-authorization-validate-argument-should-also-handle-a-single-non-array-entry branch September 13, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pull requests
Development

Successfully merging this pull request may close these issues.

Authorization validate argument should also handle a single (non-array) entry
3 participants