Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a component to be specified for antora-add-notes #35

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

recrwplay
Copy link
Contributor

@recrwplay recrwplay commented Feb 19, 2025

In multi-component builds, the extension will produce a ton of errors because the include statement for the partial can only be resolved for the default component.

This update adds support for a page-add-notes-component attribute that can be set to specify the component that contains the notes module, so the include statements always resolve.

@recrwplay recrwplay changed the title Allow a component to be specified Allow a component to be specified for antora-add-notes Feb 19, 2025
@neo-technology-commit-status-publisher
Copy link

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@recrwplay recrwplay merged commit f6e0112 into dev Feb 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants