-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding CMEK info #327
adding CMEK info #327
Conversation
… Start with just an example on how to get the auth token in Python
editing formatting of python example
updating formatting
Co-authored-by: Nicola Vitucci <[email protected]>
Co-authored-by: Nicola Vitucci <[email protected]>
updating capitalization
removing header so I avoid a section level warning
add label
adding beta info
add info re: delays when disabling a key
updating based on engineer feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few suggestions.
Co-authored-by: Nicola Vitucci <[email protected]>
Update as per Elfreda's slack request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some editorial comments :)
Co-authored-by: Jessica Wright <[email protected]>
Co-authored-by: Jessica Wright <[email protected]>
Co-authored-by: Jessica Wright <[email protected]>
Co-authored-by: Jessica Wright <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This last bit was a bit tricky, but I think I got it. Please verify.
Co-authored-by: Jessica Wright <[email protected]>
Co-authored-by: Jessica Wright <[email protected]>
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
adding CMEK information in regards to AWS