Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding CMEK info #327

Merged
merged 39 commits into from
Apr 18, 2024
Merged

adding CMEK info #327

merged 39 commits into from
Apr 18, 2024

Conversation

fiquick
Copy link
Collaborator

@fiquick fiquick commented Mar 10, 2024

adding CMEK information in regards to AWS

@fiquick fiquick closed this Mar 11, 2024
@fiquick fiquick reopened this Mar 11, 2024
@fiquick fiquick requested a review from nvitucci March 11, 2024 10:56
@fiquick fiquick marked this pull request as ready for review March 11, 2024 10:56
fiquick added 9 commits March 11, 2024 11:19
removing header so I avoid a section level warning
adding beta info
add info re: delays when disabling a key
updating based on engineer feedback
Copy link
Contributor

@nvitucci nvitucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few suggestions.

@fiquick fiquick requested a review from AlexicaWright April 5, 2024 13:33
Copy link
Collaborator

@AlexicaWright AlexicaWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editorial comments :)

Copy link
Collaborator

@AlexicaWright AlexicaWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This last bit was a bit tricky, but I think I got it. Please verify.

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@fiquick fiquick merged commit ca83783 into main Apr 18, 2024
4 checks passed
@fiquick fiquick deleted the CMEK branch April 18, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants