Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for advanced metrics #320

Merged
merged 17 commits into from
Mar 19, 2024
Merged

Conversation

SeBBBe
Copy link
Contributor

@SeBBBe SeBBBe commented Feb 20, 2024

This PR adds documentation for the Ops Manager team's upcoming Aura feature - Advanced Metrics.

Copy link
Contributor

@eve-bright eve-bright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Some nitpicks....

[NOTE]
====
Some charts can be toggled between absolute and relative values using the *%* toggle.
====
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this note would be better at the end of the section in terms of flow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that that would put it under last subheading 🤔 Perhaps I could move it up to the end of the first section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am/was considering adding a section on "chart interactions" that would include:

  • % toggle
  • Disabling data series
  • Zooming

But I feel like they're mostly pretty self explanatory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - I think so too. And probably more confusing to try to describe them!

Bottom of the first section works for me.

@SeBBBe SeBBBe marked this pull request as ready for review February 28, 2024 14:12
@SeBBBe SeBBBe requested a review from SaschaPeukert March 6, 2024 14:46
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@fiquick fiquick removed the request for review from SaschaPeukert March 19, 2024 09:07
. Select the *Metrics* tab.
. Select the *Advanced metrics* button.

The presented metrics will be laid out across three tabs according to their category:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The presented metrics will be laid out across three tabs according to their category:
The presented metrics are laid out across three tabs according to their category:


* *Expand* - Offers a better view of a particular metric by expanding the chart to take up all the available screen estate.

* *More info* - Selecting *More info* brings up an explanation of the particular metric. For some metrics it also provides hints about possible actions to take if that metric falls outside the expected range.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* *More info* - Selecting *More info* brings up an explanation of the particular metric. For some metrics it also provides hints about possible actions to take if that metric falls outside the expected range.
* *More info* - Selecting *More info* brings up an explanation of the particular metric.
For some metrics it also provides hints about possible actions to take if that metric falls outside the expected range.


=== Zoom

To zoom in to a narrower time interval, select and drag inside any chart to select your desired time interval. The data will automatically update to match the increased resolution.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To zoom in to a narrower time interval, select and drag inside any chart to select your desired time interval. The data will automatically update to match the increased resolution.
To zoom in to a narrower time interval, select and drag inside any chart to select your desired time interval.
The data is automatically updated to match the increased resolution.

Always use present tense and one sentence per line.

@fiquick fiquick merged commit 8c95ca0 into neo4j:main Mar 19, 2024
4 checks passed
@SeBBBe SeBBBe deleted the advanced-metrics branch March 19, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants