Fixes #4355: The apoc.metrics.get throws an URLAccessChecker error #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
added
to-cherry-pick
vga91
changed the title
vga91
added a commit
that referenced
this pull request
Feb 18, 2025
vga91
added a commit
that referenced
this pull request
Feb 24, 2025
vga91
added a commit
that referenced
this pull request
Feb 25, 2025
vga91
added a commit
that referenced
this pull request
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4355
The problem is due to the Mode of the procedure.
With DBMS, the URLAccessChecker.checkURL(url) blocks the execution and throws the
LOAD ... is not allowed for user ...error, because reading CSVs requires the procedure to beREAD(which is the default mode).Consistently with apoc.load.csv and the other load procedures
Changes
Procedure.Modeannotation from the 3 proceduresshouldGetMetricstestneo4j.system.check_point.total_timedoesn't work, as has been replaced byneo4j.database.system.check_point.total_timesettingshouldGetMetricstest to check all possible metrics retrieved via theapoc.metrics.listprocedureshouldGetMetricscatch block to facilitate debug in case of CI errorChangedgetStreamConnectiontoreaderFor, consistently with the apoc.load.csv procedure (see here)not possible, since in this way it prepends
/var/lib/neo4j/importto path, see here