Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci errors 2025.01.0 #4347

Merged
merged 17 commits into from
Feb 17, 2025
Merged

Fix ci errors 2025.01.0 #4347

merged 17 commits into from
Feb 17, 2025

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Feb 10, 2025


Why this error? https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/13203859002/job/36862210777?pr=4346#step:11:538
Why this error: https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/13237347264/job/36944899488?pr=4347#step:11:137
- to solve it, changed if-else, with just if, therefore we try to download from mavenCentral if the codeartifactURL is not null but for some reason the pkg is not present in aws

@vga91 vga91 force-pushed the fix-ci-errors-2025.01.0 branch from 95270a5 to 2ffc3af Compare February 10, 2025 09:26
@vga91 vga91 force-pushed the fix-ci-errors-2025.01.0 branch from 092af9b to 57fbf2c Compare February 10, 2025 10:31
@vga91 vga91 force-pushed the fix-ci-errors-2025.01.0 branch from 57fbf2c to 6dff274 Compare February 10, 2025 10:36
@vga91 vga91 force-pushed the fix-ci-errors-2025.01.0 branch from f8bf699 to 6505c38 Compare February 10, 2025 10:57
@vga91 vga91 force-pushed the fix-ci-errors-2025.01.0 branch from 6505c38 to 8afdded Compare February 10, 2025 11:11
@vga91 vga91 force-pushed the fix-ci-errors-2025.01.0 branch 2 times, most recently from e4d9188 to d9e9466 Compare February 10, 2025 13:24
@vga91 vga91 force-pushed the fix-ci-errors-2025.01.0 branch from d9e9466 to d38148c Compare February 10, 2025 13:27
@vga91
Copy link
Collaborator Author

vga91 commented Feb 10, 2025

This fails due to Core jars: 56c1ad8

@vga91 vga91 force-pushed the fix-ci-errors-2025.01.0 branch from b0a90c9 to 1669b7e Compare February 10, 2025 15:19
@vga91
Copy link
Collaborator Author

vga91 commented Feb 11, 2025

Trying by changing submodule branch

@RobertoSannino RobertoSannino merged commit fd5ed53 into 2025.01 Feb 17, 2025
5 checks passed
@RobertoSannino RobertoSannino deleted the fix-ci-errors-2025.01.0 branch February 17, 2025 11:15
vga91 added a commit to vga91/neo4j-apoc-procedures that referenced this pull request Feb 28, 2025
* De-ignored tests and solve various CI error

* Upgrade upload-artifact version (neo4j-contrib#4343)

* solve hdfs tests

* added mavenCentral() even if CODEARTIFACT_DOWNLOAD_URL is not null

* added RELEASE_BRANCH_NAME condition to get CodeArtifact URL

* try evaluate RELEASE_BRANCH_NAME at runtime

* change CI

* change CI

* cleanup

* try with workaround

* update CI

* try if-else in subprojects

* fixed hdfs tests

* revert CODEARTIFACT_DOWNLOAD_URL handling

* change submodule branch

* try CI reverting mavenCentral workaround

* Fixing CODEARTIFACT_DOWNLOAD_URL to be able to retrieve both CI and Release artifacts

---------

Co-authored-by: Omar Ahmad <[email protected]>
vga91 added a commit that referenced this pull request Feb 28, 2025
* De-ignored tests and solve various CI error

* Upgrade upload-artifact version (#4343)

* solve hdfs tests

* added mavenCentral() even if CODEARTIFACT_DOWNLOAD_URL is not null

* added RELEASE_BRANCH_NAME condition to get CodeArtifact URL

* try evaluate RELEASE_BRANCH_NAME at runtime

* change CI

* change CI

* cleanup

* try with workaround

* update CI

* try if-else in subprojects

* fixed hdfs tests

* revert CODEARTIFACT_DOWNLOAD_URL handling

* change submodule branch

* try CI reverting mavenCentral workaround

* Fixing CODEARTIFACT_DOWNLOAD_URL to be able to retrieve both CI and Release artifacts

---------

Co-authored-by: Omar Ahmad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants