-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci errors 2025.01.0 #4347
Merged
Merged
Fix ci errors 2025.01.0 #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82eb2d2
to
95270a5
Compare
95270a5
to
2ffc3af
Compare
092af9b
to
57fbf2c
Compare
57fbf2c
to
6dff274
Compare
f8bf699
to
6505c38
Compare
6505c38
to
8afdded
Compare
e4d9188
to
d9e9466
Compare
d9e9466
to
d38148c
Compare
This fails due to Core jars: 56c1ad8 |
b0a90c9
to
1669b7e
Compare
Trying by changing submodule branch |
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Feb 28, 2025
* De-ignored tests and solve various CI error * Upgrade upload-artifact version (neo4j-contrib#4343) * solve hdfs tests * added mavenCentral() even if CODEARTIFACT_DOWNLOAD_URL is not null * added RELEASE_BRANCH_NAME condition to get CodeArtifact URL * try evaluate RELEASE_BRANCH_NAME at runtime * change CI * change CI * cleanup * try with workaround * update CI * try if-else in subprojects * fixed hdfs tests * revert CODEARTIFACT_DOWNLOAD_URL handling * change submodule branch * try CI reverting mavenCentral workaround * Fixing CODEARTIFACT_DOWNLOAD_URL to be able to retrieve both CI and Release artifacts --------- Co-authored-by: Omar Ahmad <[email protected]>
vga91
added a commit
that referenced
this pull request
Feb 28, 2025
* De-ignored tests and solve various CI error * Upgrade upload-artifact version (#4343) * solve hdfs tests * added mavenCentral() even if CODEARTIFACT_DOWNLOAD_URL is not null * added RELEASE_BRANCH_NAME condition to get CodeArtifact URL * try evaluate RELEASE_BRANCH_NAME at runtime * change CI * change CI * cleanup * try with workaround * update CI * try if-else in subprojects * fixed hdfs tests * revert CODEARTIFACT_DOWNLOAD_URL handling * change submodule branch * try CI reverting mavenCentral workaround * Fixing CODEARTIFACT_DOWNLOAD_URL to be able to retrieve both CI and Release artifacts --------- Co-authored-by: Omar Ahmad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manual cherry-pick: f3bb30d
cherry-pick Fixing CODEARTIFACT_DOWNLOAD_URL to be able to retrieve both CI and Release artifacts #4354
Replaced MapUtils with ExtendedMapUtils here,
otherwise we have a ClassNotFound error
solved hadoop test errors by changing build.gradle
Why this error? https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/13203859002/job/36862210777?pr=4346#step:11:538Why this error: https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/13237347264/job/36944899488?pr=4347#step:11:137- to solve it, changed if-else, with just if, therefore we try to download from mavenCentral if the codeartifactURL is not null but for some reason the pkg is not present in aws