EC Recover #3696
EC Recover #3696
Conversation
|
@neo-project/core Please take special look into |
| /// <param name="hashAlgorithm">The hash algorithm to be used hash the message.</param> | ||
| /// <returns>The recovered public key in compressed format, or null if recovery fails.</returns> | ||
| [ContractMethod(Hardfork.HF_Echidna, CpuFee = 1 << 10, Name = "recoverSecp256K1")] | ||
| public static byte[] RecoverSecp256K1(byte[] message, byte[] signature, HashAlgorithm hashAlgorithm) |
There was a problem hiding this comment.
@shargon Hi shagon, i think what we should handle is passing the hash and signature, since the message sometimes require special format to be hashed which is not possible to be handled by our native contract, such as keccak256(abi.encodePacked("\x19Ethereum Signed Message:\n32", hash)) . So we should leave the hash thing to the costum contract.
There was a problem hiding this comment.
HasAlgoritm.None is allowed
There was a problem hiding this comment.
@Jim8y Check this recent conversation #3696 (comment).
There was a problem hiding this comment.
Maybe Jimmy's input could be taken as a hint that the current function signature might be misleading if one is not aware of HashAlgorithm.None.
I'm not strongly opinionated on this, but it might be better to just remove the HashAlgorithm parameter from the function signature. Then, it might be more clear that all the function does - as its name says - is recover the public key.
Description
Close #3628
Alternative to #3633
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: