Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: before implementation with custom processors #2421

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

bobvandevijver
Copy link
Contributor

Description

The before implementation was never functional, as the returned tags array is a tag name indexed array of tags. This change resolves that, and adds a test to actually insert a processor with the before attribute.

image

What type of PR is this? (check all applicable)

  • Bug Fix
  • Feature
  • Refactor
  • Deprecation
  • Breaking Change
  • Documentation Update
  • CI

Checklist

  • I have made corresponding changes to the documentation (docs/)
  • I have made corresponding changes to the changelog (CHANGELOG.md)

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.56%. Comparing base (13408ab) to head (e438007).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2421      +/-   ##
==========================================
+ Coverage   89.53%   89.56%   +0.03%     
==========================================
  Files          78       78              
  Lines        2915     2914       -1     
==========================================
  Hits         2610     2610              
+ Misses        305      304       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DjordyKoert DjordyKoert merged commit e44364d into nelmio:master Jan 17, 2025
25 checks passed
@DjordyKoert
Copy link
Collaborator

Thank you!

@bobvandevijver bobvandevijver deleted the fix-before branch January 17, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants