fix CI #2162
Merged
fix CI #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
DjordyKoert
approved these changes
Dec 8, 2023
| - php-version: 8.1 | ||
| symfony-require: "6.3.*" | ||
| - php-version: 8.2 | ||
| symfony-require: "6.4.*" |
There was a problem hiding this comment.
Php 8.1 is still supported by this version, we could also add a test for this
|
@GuilhemN ci fails because a deprecation warning is not present in the phpunit baseline. Generating a new baseline should fix it.
|
|
Thanks a lot @smoench! Best wishes for the new year. |
|
Also small question from my end @GuilhemN. Are you planning to make a new release for the Symfony 7 support after this is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusted following:
set-ouputwith$GITHUB_OUTPUTflexviashivammathur/setup-phptoolsphpunitas it faster, cached by actions composer cache and fixes an error on PHP 7.2