fix(SymfonyConstraintAnnotationReader): added functional tests

nelmio · Aug 2, 2024 · 00b9d1d · 00b9d1d
1 parent b5b8149
commit 00b9d1d
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/tests/Functional/Entity/SymfonyConstraintsWithValidationGroups80.php b/tests/Functional/Entity/SymfonyConstraintsWithValidationGroups80.php
@@ -43,4 +43,12 @@ class SymfonyConstraintsWithValidationGroups80
      * @Assert\Valid
      */
     public $propertyArray;
+
+    /**
+     * @var ?string
+     *
+     * @Groups({"test"})
+     * @Assert\NotNull(groups={"test"})
+     */
+    public $propertyNotNullOnSpecificGroup;
 }
diff --git a/tests/Functional/Entity/SymfonyConstraintsWithValidationGroups81.php b/tests/Functional/Entity/SymfonyConstraintsWithValidationGroups81.php
@@ -37,4 +37,11 @@ class SymfonyConstraintsWithValidationGroups81
     #[OA\Property(type: 'array', items: new OA\Items(type: 'string'))]
     #[Assert\Valid]
     public $propertyArray;
+
+    /**
+     * @var ?string
+     */
+    #[Groups(['test'])]
+    #[Assert\NotNull(groups: ['test'])]
+    public $propertyNotNullOnSpecificGroup;
 }
diff --git a/tests/Functional/ValidationGroupsFunctionalTest.php b/tests/Functional/ValidationGroupsFunctionalTest.php
@@ -35,13 +35,17 @@ public function testConstraintGroupsAreRespectedWhenDescribingModels(): void
         $expected = [
             'required' => [
                 'property',
+                'propertyNotNullOnSpecificGroup',
             ],
             'properties' => [
                 'property' => [
                     'type' => 'integer',
                     // the min/max constraint is in the default group only and shouldn't
                     // be read here with validation groups turned on
                 ],
+                'propertyNotNullOnSpecificGroup' => [
+                    'type' => 'string',
+                ],
             ],
             'type' => 'object',
             'schema' => 'SymfonyConstraintsTestGroup',
@@ -75,6 +79,10 @@ public function testConstraintDefaultGroupsAreRespectedWhenReadingAnnotations():
                         'type' => 'string',
                     ],
                 ],
+                'propertyNotNullOnSpecificGroup' => [
+                    'type' => 'string',
+                    'nullable' => true,
+                ],
             ],
             'type' => 'object',
             'schema' => 'SymfonyConstraintsDefaultGroup',