feat: use SSO term instead of Nafath #248
Draft
+166
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadinaif
force-pushed
the
shadinaif/allow-multi-saml-config
branch
2 times, most recently
from
7a4aaa4 to
d04b644
Compare
And allow fetching user data when multiple SSO configs are available for the same site
shadinaif
force-pushed
the
shadinaif/allow-multi-saml-config
branch
from
d04b644 to
fbe4d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use SSO term instead of Nafath, and allow fetching user data when multiple SSO configs are available for the same site. The problem we have now is having multiple SSO entity IDs to be reported. Therefore, instead of
FX_NAFATH_ENTRY_IDwe'll useFX_SSO_INFOas a general term that contains a needed entity IDs along their basic information. The order of items in theFX_SSO_INFOsettings will be respected when reporting the user's external ID. Only the first found ID will be reportedRelated Issue: #64