Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom necl dependencies #5

Merged

Conversation

andrey-canon
Copy link
Collaborator

@andrey-canon andrey-canon commented Dec 2, 2024

Description

This updates frontend-platform and brand-openedx dependencies and finally set the custom styles issue

How to test?

  1. Delete node modules folder and run npm install
  2. Open discussion -> the mfe must load with default color
  3. Add the following setting and check discussion page -> the mfe must load with red color
  "CUSTOM_PRIMARY_COLORS": {
    "pgn-color-primary-base": "#AA0000"
  },
  1. Add the following setting and check discussion page -> the mfe must load with green color
  "PARAGON_THEME_URLS": {
    "core": {
        "url": "https://cdn.jsdelivr.net/combine/npm/@edx/[email protected]/styles/css/themes/light/utility-classes.min.css,npm/@edx/[email protected]/dist/core.min.css"
    },
    "defaults": {
        "light": "light"
    },
    "variants": {
        "light": {
            "url": "https://css-varsify.s3.amazonaws.com/public/a9959998-0bab-4447-ada5-6819866195f3.css"
        }
    }
  },
  1. check the typography

Result

image

Copy link
Collaborator

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
custom_primay colors

Screenshot from 2024-12-04 11-31-14

PARAGON_THEME_URLS

Screenshot from 2024-12-04 11-33-12

@andrey-canon andrey-canon merged commit c34666c into open-release/redwood.nelp Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants