Updated clang-tidy configuration, scripts, and Makefiles

.clang-tidy

@@ -1,4 +1,4 @@
-Checks: -*,modernize-use-default-member-init,modernize-loop-convert,modernize-use-bool-literals,modernize-deprecated-headers,performance-unnecessary-value-param,performance-faster-string-find,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-use-nullptr,modernize-use-override
+Checks: -*,google-readability-braces-around-statements,google-readability-casting,modernize-use-using,modernize-loop-convert,modernize-use-bool-literals,modernize-deprecated-headers,performance-unnecessary-value-param,performance-faster-string-find,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-use-nullptr,modernize-use-override,performance-unnecessary-copy-initialization
 CheckOptions:
   - key: modernize-use-default-member-init.UseAssignment
     value: '1'

build/tidy.mk

@@ -20,8 +20,8 @@ Clang_Tidy_Options = -fix -fix-errors
 # just the C and C++ sources so we don't pick up lex and yacc files
 # for example.
 
-Clang_Tidy_CC_Files = $(filter %.c, $(sort $(1)))
-Clang_Tidy_CXX_Files = $(filter %.cc, $(sort $(1)))
+Clang_Tidy_CC_Files = $(filter %.c, $(sort $^))
+Clang_Tidy_CXX_Files = $(filter %.cc, $(sort $^))
 
 # clang-tidy rules. We expect these to be actions with something like
 # $(DIST_SOURCES) as the dependencies.rules. Note that $DIST_SOURCES
@@ -30,5 +30,5 @@ Clang_Tidy_CXX_Files = $(filter %.cc, $(sort $(1)))
 #
 # All this clearly requires GNU make.
 
-CXX_Clang_Tidy = $(foreach tidy_target, $(call Clang_Tidy_CXX_Files,$^), $(CLANG_TIDY) $(Clang_Tidy_Options) $(tidy_target) -- $(CXXCOMPILE) -x c++;)
-CC_Clang_Tidy = $(foreach tidy_target, $(call Clang_Tidy_CC_Files,$^), $(CLANG_TIDY) $(Clang_Tidy_Options) $(tidy_target) -- $(COMPILE) -x c;)
+CXX_Clang_Tidy = $(CLANG_TIDY) $(Clang_Tidy_Options) $(Clang_Tidy_CXX_Files) -- $(CXXCOMPILE) -x c++
+CC_Clang_Tidy = $(CLANG_TIDY) $(Clang_Tidy_Options) $(Clang_Tidy_CC_Files) -- $(COMPILE) -x c

example/plugins/cpp-api/Makefile.am

@@ -106,4 +106,3 @@ intercept_la_LIBADD = $(libtscppapi)
 
 clang-tidy-local: $(DIST_SOURCES)
 	$(CXX_Clang_Tidy)
-	$(CC_Clang_Tidy)

proxy/http/remap/Makefile.am

@@ -81,7 +81,7 @@ test_PluginFactory_SOURCES = \
 	RemapPluginInfo.cc
 
 test_RemapPluginInfo_CPPFLAGS = $(AM_CPPFLAGS) -I$(abs_top_srcdir)/tests/include -DPLUGIN_DSO_TESTS
-	EXTRA_test_RemapPluginInfo_DEPENDENCIES = \
+EXTRA_test_RemapPluginInfo_DEPENDENCIES = \
 	unit-tests/plugin_missing_init.la \
 	unit-tests/plugin_missing_doremap.la \
 	unit-tests/plugin_missing_deleteinstance.la \

src/tscore/Makefile.am

@@ -125,7 +125,6 @@ else
 HKDF_impl = HKDF_openssl.cc
 endif
 libtscore_la_SOURCES += \
-  HKDF.h \
   $(HKDF_impl)
 endif