chore: Update dependencies and improve the types #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necolas
reviewed
Nov 6, 2024
| $$css?: empty, | ||
| [key: string]: number | string, | ||
| }; | ||
| [key: string]: mixed, |
There was a problem hiding this comment.
Why does the value need to change to mixed?
There was a problem hiding this comment.
I did this to account for things like Animated values. It's not strictly neccessary.
I wanted to put this up and ask about whether I should set up the scripts to generate Flow and TS type defs. Then I can update the Flow version as well.
There was a problem hiding this comment.
On web, we're not going to get Animated values
Why do we need a script to generate type defs instead of just manually managing the really small def files that already exist?
There was a problem hiding this comment.
I can do it manually too. A script ensures we don't accidentally write the wrong types, but it is very small, so I can do it manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts updates some of the dependencies and improves some of the types.
TODO: This package doesn't export any types right now. Fixing this will need more build scripts.