Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVCPLAN-4492: create quota class #7

Merged
merged 1 commit into from
Dec 7, 2023
Merged

SVCPLAN-4492: create quota class #7

merged 1 commit into from
Dec 7, 2023

Conversation

jakerundall
Copy link
Contributor

Also:

  • pdk validate
  • pdk update

@jakerundall jakerundall self-assigned this Dec 6, 2023
@jakerundall jakerundall marked this pull request as draft December 6, 2023 22:36
@jakerundall jakerundall force-pushed the rundall/SVCPLAN-4492/create_quota_class branch 2 times, most recently from 4b9387d to cf82b32 Compare December 7, 2023 15:56
@jakerundall jakerundall requested a review from billglick December 7, 2023 15:59
@jakerundall jakerundall marked this pull request as ready for review December 7, 2023 16:00
@jakerundall
Copy link
Contributor Author

I've tested on two test login nodes on Magnus, one w/o Duo (mgtest01) and one w/ Duo (mgtesthn1). I made sure root can log in without the quota command running (the other default user to skip is qualys). And made sure it does show for rundall (with shell set to Bash, tcsh, and zsh). I also coded it so the quota doesn't when a user switches identity (via sudo or su).

billglick
billglick requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@billglick billglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor suggested changes.
And then some random comments that don't require any changes at this time.

manifests/quota.pp Outdated Show resolved Hide resolved
manifests/quota.pp Outdated Show resolved Hide resolved
manifests/quota.pp Show resolved Hide resolved
manifests/quota.pp Outdated Show resolved Hide resolved
templates/quota.sh.epp Outdated Show resolved Hide resolved
@jakerundall jakerundall force-pushed the rundall/SVCPLAN-4492/create_quota_class branch from 9939094 to bb25180 Compare December 7, 2023 17:15
@jakerundall
Copy link
Contributor Author

Ready for another look, thanks!

billglick
billglick requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@billglick billglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed renaming the quota timeout_interval_seconds parameter in the hiera data.

data/common.yaml Outdated Show resolved Hide resolved
@jakerundall
SVCPLAN-4492: create quota class
a034e11 
Also:
- pdk validate
- pdk update
@jakerundall jakerundall force-pushed the rundall/SVCPLAN-4492/create_quota_class branch from 5c2d8bf to a034e11 Compare December 7, 2023 18:06
billglick
billglick approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@billglick billglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jakerundall jakerundall merged commit a034e11 into main Dec 7, 2023
4 checks passed
@jakerundall jakerundall deleted the rundall/SVCPLAN-4492/create_quota_class branch December 7, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billglick billglick billglick approved these changes

Assignees

@jakerundall jakerundall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakerundall @billglick