Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDS DRS mapping data #728

Merged
merged 10 commits into from
Dec 12, 2024
Merged

Conversation

onursumer
Copy link
Collaborator

@onursumer onursumer commented Dec 5, 2024

Fix #719

From:
image
to:
image

Lots of images were actually not on CDS yet. We had incorrectly assumed several CDS releases were already available in #721). Prior to that the dropdown looked like this, so 6155 new files are now available from CDS (added to the release notes).

image

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
htan-portal-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 3:13am

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to update this file. original json should still be the same.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, actually, the file has changed. @inodb did you run the python script again to update the data?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's also possible that you had the previous version locally and never updated it to the latest

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - fixed this now!

@inodb inodb added the bug Something isn't working label Dec 12, 2024
@inodb inodb merged commit 0d4e700 into ncihtan:master Dec 12, 2024
2 checks passed
@onursumer onursumer deleted the update-cds-drs-mapping branch December 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two sources of truth for whether a file is on CDS (drs_uri & CDS_Release column)
2 participants