Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add the possibility to add a request id #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Nov 16, 2022

With this PR, you can do now something like this (for example I will take FMA ontology)

ontology.explore.submission(1) # will call https://data.bioontology.org/ontologies/FMA/submissions/1

or

ontology.explore.classes("http://purl.org/sig/ont/fma/fma65139") # will call https://data.bioontology.org/ontologies/FMA/classes/http%3A%2F%2Fpurl.org%2Fsig%2Font%2Ffma%2Ffma65139

(deprecating the single_class: "https://data.bioontology.org/ontologies/FMA/classes/{class_id}" link)

It may sound simple, but was not possible before (as far as I know)

@alexskr
Copy link
Member

alexskr commented Jul 25, 2024

@syphax-bouazzouni, is this PR up to date and is it safe to merge?

@syphax-bouazzouni
Copy link
Author

@syphax-bouazzouni, is this PR up to date and is it safe to merge?

Yes, it is up to date and safe, as it has been in production at Agroportal for 1,5 years.

@alexskr alexskr requested a review from jvendetti July 25, 2024 17:04
@jvendetti jvendetti self-assigned this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants