Implement the TextDefinitionReplacement ontology change request type #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| %div{id: 'editDefinitionFormDiv', 'data-change-requests-target': 'proposalForm'} | ||
| - else | ||
| -# Note: get_link_for_cls_ajax is in application_helper.rb, it calls auto_link when necessary. | ||
| - ajax_links = values.map {|v| get_link_for_cls_ajax(v, @ontology.acronym, '_blank') } |
Check notice
Code scanning / Brakeman
Unescaped parameter value. Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and improvements to the change request process. It adds support for the TextDefinitionReplacement change request type, enabling users to request modifications to the definitions of ontology classes.
Additionally, it improves error handling by addressing cases where users provide an invalid GitHub repository name or attempt to use a repository with the issue tracker disabled.
The code responsible for hiding change request forms on Cancel and Submit actions has been refactored to be more generic and reusable, ensuring consistency across all change request forms, regardless of type.
Changes to the
concepts/_detailspartial were intentionally kept minimal, with the knowledge that this area of the application is undergoing a redesign.Resolves #381