Raise 404 for invalid source or target ontologies

Fixes #210
ncbo · Apr 17, 2023 · ee324c0 · ee324c0
1 parent 3e1e797
commit ee324c0
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/app/controllers/mappings_controller.rb b/app/controllers/mappings_controller.rb
@@ -46,11 +46,14 @@ def count
   end
 
   def show
-    page = params[:page] || 1
     @ontology = LinkedData::Client::Models::Ontology.find_by_acronym(params[:id]).first
+    not_found if @ontology.nil?
+
     @target_ontology = LinkedData::Client::Models::Ontology.find(params[:target])
-    ontologies = [@ontology.acronym, @target_ontology.acronym]
+    not_found if @target_ontology.nil?
 
+    page = params[:page] || 1
+    ontologies = [@ontology.acronym, @target_ontology.acronym]
     @mapping_pages = LinkedData::Client::HTTP.get(MAPPINGS_URL, {page: page, ontologies: ontologies.join(",")})
     @mappings = @mapping_pages.collection
     @delete_mapping_permission = check_delete_mapping_permission(@mappings)