PD-5201 Change empty fields to NA

ncbi · Dec 20, 2024 · 09d052a · 09d052a
1 parent 0ef7cc0
commit 09d052a
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 7 deletions.
diff --git a/amr_report.cpp b/amr_report.cpp
@@ -58,7 +58,6 @@ namespace
 constexpr bool useCrossOrigin = false;  // GPipe: true
 constexpr double frac_delta = 1e-5;  
 constexpr size_t domain_min = 20;  // aa
-const string na ("NA");
 
 bool ident_min_user = false;
 bool equidistant = false;
@@ -656,7 +655,7 @@ struct BlastAlignment final : Alignment
       	      td << input_name;;
             td << (targetProt ? nvl(targetName, na) : na);  // PD-2534
   	        if (cdsExist)
-  	          td << (empty () ? na : (cds. contig. empty () ? nvl (targetName,na)  : cds. contig))
+  	          td << (empty () ? na : (cds. contig. empty () ? nvl (targetName, na)  : cds. contig))
   	             << (empty () ? 0  : (cds. contig. empty () ? targetStart : cds. start) + 1)
   	             << (empty () ? 0  : (cds. contig. empty () ? targetEnd  : cds. stop))
   	             << (empty () ? na : (cds. contig. empty () ? (targetStrand ? "+" : "-") : (cds. strand ? "+" : "-")));

diff --git a/amrfinder.cpp b/amrfinder.cpp
@@ -33,6 +33,7 @@
 * Dependencies: NCBI BLAST, HMMer, libcurl, gunzip (optional)
 *
 * Release changes:
+*   4.0.9   12/20/2024 PD-5201  SrxTyper ver. 1.0.32
 *   4.0.8   12/18/2024 PD-5181  StxTyper ver. 1.0.31
 *           12/14/2024 PD-5191  stxtyper --threads
 *   4.0.7   12/12/2024 PD-5192  StxTyper ver. 1.0.30
@@ -342,7 +343,7 @@ using namespace GFF_sp;
 const string dataVer_min ("2024-08-14.2");
   // 3.12: "2023-12-15.2"
   // 3.11: "2021-02-18.1"  
-const string stxTyperVersion ("1.0.31");  
+const string stxTyperVersion ("1.0.32");  
 
 
 

diff --git a/columns.hpp b/columns.hpp
@@ -66,4 +66,5 @@ constexpr const char* hierarchyNode_colName = "Hierarchy node";
 
 // PD-5155
 constexpr const char* fusion_infix = "::";  // was: "/"
-
+
+constexpr const char* na ("NA");
diff --git a/dna_mutation.cpp b/dna_mutation.cpp
@@ -108,7 +108,7 @@ struct BlastnAlignment final : Alignment
     }
   void report (TsvOut& td,
                bool mutationAll) const 
-    { const string na ("NA");
+    { //const string na ("NA");
       for (const SeqChange& seqChange : seqChanges)
       {
         VectorPtr<AmrMutation> mutations (seqChange. mutations);

diff --git a/stx b/stx
diff --git a/version.txt b/version.txt
@@ -1 +1 @@
-4.0.8
+4.0.9
Original file line number	Diff line number	Diff line change
Expand Up		@@ -66,4 +66,5 @@ constexpr const char* hierarchyNode_colName = "Hierarchy node";

		// PD-5155
		constexpr const char* fusion_infix = "::"; // was: "/"


		constexpr const char* na ("NA");
+2 −1		amrfinder_columns.hpp
+17 −15		stxtyper.cpp
+1 −1		test/cases.expected
+3 −3		test_stxtyper.sh
+1 −1		version.txt