Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to delete objects #6

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

mreinfurt
Copy link

Hi,

your package is still working great. However, due to the outdated dependencies, conflicts can arise trying to use it with other more up-to-date libs.

Especially since there was a major version upgrade for the xml lib (3.0 to 4.0) even though it's non-breaking. Just by updating this dependency, dospace already works with more up-2-date libs.

Thanks!
Manuel

@kaetemi
Copy link
Member

kaetemi commented Sep 17, 2020

I'll check it, thanks!

@mreinfurt
Copy link
Author

In the meantime, I've added a function to delete objects in Digital Ocean Spaces. Of course, you don't need to merge this one. Just updating the XML-dependency might be worth it already.

Thanks!

@kaetemi kaetemi changed the title Update dependencies to ensure compatibility Add function to delete objects Oct 8, 2020
@kaetemi
Copy link
Member

kaetemi commented Jan 24, 2022

@salihgueler @GraSim Can someone check if this needs any changes for null safety?

@jpetro416
Copy link

How is anyone deleting things?

@jpetro416
Copy link

@mreinfurt I'm having an issue signing the request with a value for sha256. What should I sign the delete with?

@mreinfurt
Copy link
Author

@jpetro416 I haven't worked with it for quite some time now. I just contacted another dev who has been using it lately, @dernoun. Perhaps he can answer it. :)

@jpetro416
Copy link

jpetro416 commented Mar 20, 2022

@mreinfurt Okay thanks, I still can't figure out what value it needs for that signRequest. Digital Ocean needs a sha256 value to auth when running a delete command. I'm not sure how to generate it (https://stackoverflow.com/questions/67040184/cant-replicate-simple-hashing-signature-example-from-amazon) might be an answer, but I know the upload function has the correct sha value in it's signRequest. Maybe they could match this sha value and add it to your patch, others are looking for a solution here: #12

@professorsnapy
Copy link

@mreinfurt @kaetemi Is this fixed? I too am facing this issue with delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants