Hw04-GC #4
Open
Hw04-GC #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kataus
reviewed
Mar 7, 2020
| Выводы: | ||
| 1. Наилучший сборщик для данной задачи - G1. При его использовании больше всего количество операций с хранилищем и | ||
| время жизни программы до OOM. При этом наименьшее время потрачено на сборки. | ||
| 2. Serial и CMS примерно одинаковы по параметрам |
There was a problem hiding this comment.
Не соглашусь... Serial довольно быстро отработал на фоне остальных. Это тоже полезный навык
kataus
reviewed
Mar 7, 2020
| // printMetrics("ADD", storage.size(), getTimeSpent()); | ||
|
|
||
| for (int i = 0; i < MAX_SIZE; i++) { | ||
| storage.add(new String(new char[255])); |
There was a problem hiding this comment.
Spring не лучший выбор для теста. У него несколько специфические отношения с памятью. Лучше взять Integer
kataus
reviewed
Mar 7, 2020
|
|
||
| // printMetrics("REMOVE", storage.size(), getTimeSpent()); | ||
|
|
||
| int eraseAmount = storage.size()/10; |
There was a problem hiding this comment.
10% под сборку не интересно. Так сборщику работы немного. Давайте хоть половину удалять
kataus
reviewed
Mar 7, 2020
| @@ -0,0 +1,15 @@ | |||
| Тестовое окружение: JDK 9, MacOS 10.13.6, Corei5 1.6 GHz, 8Gb RAM | |||
| VM Options: -Xms256m -Xmx256m | |||
There was a problem hiding this comment.
Памяти совсем мало... Так не интересно. Давайте хоть гиг дадим, а то Parrallel просто негде развернуться
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Garbage collectors