Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just tried loading connectors from the VFB CATMAID:
Turns out that the link ID -> type map hard-coded in
pymaid.config
is different for that CATMAID instance.This PR changes three things to fix the issue:
pymaid.config.get_link_types(remote_instance)
, that fetches the map and caches it for subsequent use.__hash__
method forCatmaidInstance
that generates the hash based on server url, token, project ID and http user/password. This is so that changing any of the relevant properties will also change the hash and lead to re-caching of the link map (and possibly other stuff in the future).name
andtype
(plus a bunch of other variables). Previously we used thetype
to populate the corresponding column in the dataframe returned byget_connectors
. However, on the VFB CATMAID instance we have:type
is the same for both pre- and postsynapses. With this PR we're using thename
field instead.@clbarnes I know you're out of the game technically but so am I when it comes to CATMAID. I also don't have access to your internal CATMAID instances, so can't test there. Do you see any reason why the changes suggested there might cause problems?