fix: prompt bug in web and sync-file

navikt · Nov 22, 2023 · 527d00a · 527d00a
1 parent b582b55
commit 527d00a
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/src/actions/sync-file.ts b/src/actions/sync-file.ts
@@ -13,7 +13,7 @@ import {
 } from '../common/octokit.ts'
 import { log } from '../common/log.ts'
 import { Gitter } from '../common/git.ts'
-import inquirer from '../common/inquirer.ts'
+import inquirer, { hackilyFixBackToBackPrompt } from '../common/inquirer.ts'
 import { GIT_CACHE_DIR } from '../common/cache.ts'
 
 const reposQuery = /* GraphQL */ `
@@ -122,13 +122,16 @@ export async function syncFileAcrossRepos(query: string): Promise<void> {
     ])
 
     // Step 2, selecting a valid file in the source repo
+    await hackilyFixBackToBackPrompt()
     const fileToSync = await getValidFileInSource(sourceRepo.source)
 
     // Step 3, selecting target repos
+    await hackilyFixBackToBackPrompt()
     const otherRepos = relevantRepos.filter((it) => it.name !== sourceRepo.source)
     const targetRepos = await getTargetRepos(otherRepos)
 
     // Step 4, writing commit message
+    await hackilyFixBackToBackPrompt()
     const commitMessage = await inquirer.prompt<{ message: string }>({
         type: 'input',
         name: 'message',
@@ -140,6 +143,7 @@ export async function syncFileAcrossRepos(query: string): Promise<void> {
     log(`The commit message will be "${chalk.yellow(commitMessage.message)}"`)
 
     // Step 5, confirm
+    await hackilyFixBackToBackPrompt()
     const confirmResult = await inquirer.prompt({
         type: 'confirm',
         message: `Do you want to continue? This will create ${otherRepos.length} commits, one for each repo.`,

diff --git a/src/actions/web.ts b/src/actions/web.ts
@@ -2,7 +2,7 @@ import * as R from 'remeda'
 import open from 'open'
 import chalk from 'chalk'
 
-import inquirer from '../common/inquirer.ts'
+import inquirer, { hackilyFixBackToBackPrompt } from '../common/inquirer.ts'
 import { log } from '../common/log.ts'
 
 type Envs = {
@@ -105,6 +105,7 @@ export async function openResource(what: string | null, env: string | null): Pro
         return
     }
 
+    await hackilyFixBackToBackPrompt()
     const selectedEnv = await getAppEnv(cleanItem)
     await openApp(cleanItem, selectedEnv)
 }

diff --git a/src/common/inquirer.ts b/src/common/inquirer.ts
@@ -3,4 +3,12 @@ import inquirer from 'inquirer'
 
 inquirer.registerPrompt('autocomplete', autocomplete)
 
+/**
+ * Sometimes when inquirer propmts are invoked back to back, the second prompt
+ * will not be able to receive input. This is a hacky workaround to fix that.
+ */
+export async function hackilyFixBackToBackPrompt(): Promise<void> {
+    await new Promise((resolve) => setTimeout(resolve, 369))
+}
+
 export default inquirer