Legg til enum for FeatureToggle #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/kotlin/no/nav/familie/ks/sak/barnehagelister/KSBarnehagelisterConsumer.kt
Outdated
Show resolved
Hide resolved
stigebil
reviewed
Jan 30, 2025
src/main/kotlin/no/nav/familie/ks/sak/kjerne/behandling/HenleggBehandlingService.kt
Outdated
Show resolved
Hide resolved
stigebil
reviewed
Jan 30, 2025
src/main/kotlin/no/nav/familie/ks/sak/kjerne/behandling/HenleggBehandlingService.kt
Outdated
Show resolved
Hide resolved
…re toggleId: String til toggle: FeatureToggle i isEnabled()
…dsfordelingService
…fra-class-til-enum' into refaktorer-feautureToggleConfig-fra-class-til-enum
…fra-class-til-enum' into refaktorer-feautureToggleConfig-fra-class-til-enum
…fra-class-til-enum' into refaktorer-feautureToggleConfig-fra-class-til-enum
…fra-class-til-enum' into refaktorer-feautureToggleConfig-fra-class-til-enum
|
bragejahren
approved these changes
Feb 3, 2025
schmelita
deleted the
refaktorer-feautureToggleConfig-fra-class-til-enum
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💰 Hva skal gjøres, og hvorfor?
Samme som ba-sak: navikt/familie-ba-sak#5040
Favro: https://favro.com/organization/98c34fb974ce445eac854de0/1844bbac3b6605eacc8f5543?card=NAV-23170
Refaktorerer FeatureToggleConfig fra klasse med companion object til enum for bedre typesikring. Fremover kan enums parses direkte i Cucumber-tester, slik at testene kan bruke enum-navnene på samme måte som i koden ellers.
🔎️ Er det noe spesielt du ønsker tilbakemelding om?
✅ Checklist
Har du husket alle punktene i listen?
Jeg har ikke skrevet tester fordi:
Finnes eksisterende tester
💬 Ønsker du en muntlig gjennomgang?