Purify adapter codes

Signed-off-by: Taeik Lim <[email protected]>

spring-batch-plus/src/main/java/com/navercorp/spring/batch/plus/item/adapter/ItemStreamFluxReaderDelegate.java

@@ -21,6 +21,7 @@
 import org.springframework.batch.item.ExecutionContext;
 import org.springframework.batch.item.ItemStreamReader;
 import org.springframework.lang.NonNull;
+
 import reactor.core.publisher.Flux;
 
 /**

spring-batch-plus/src/main/java/com/navercorp/spring/batch/plus/item/adapter/ItemStreamIterableReaderAdapter.java

@@ -71,15 +71,6 @@ public T read() {
 		}
 	}
 
-	protected Iterator<? extends T> getIterator() {
-		if (this.iterator == null) {
-			this.iterator = Optional.ofNullable(this.iterable)
-				.map(Iterable::iterator)
-				.orElseThrow(() -> new IllegalStateException("No iterable is set. Call 'open' first."));
-		}
-		return this.iterator;
-	}
-
 	@SuppressWarnings("NullableProblems")
 	@Override
 	public void update(ExecutionContext executionContext) {
@@ -90,4 +81,13 @@ public void update(ExecutionContext executionContext) {
 	public void close() {
 		this.delegate.onCloseRead();
 	}
+
+	protected Iterator<? extends T> getIterator() {
+		if (this.iterator == null) {
+			this.iterator = Optional.ofNullable(this.iterable)
+				.map(Iterable::iterator)
+				.orElseThrow(() -> new IllegalStateException("No iterable is set. Call 'open' first."));
+		}
+		return this.iterator;
+	}
 }

spring-batch-plus/src/main/java/com/navercorp/spring/batch/plus/item/adapter/ItemStreamIteratorReaderDelegate.java

@@ -18,12 +18,12 @@
 
 package com.navercorp.spring.batch.plus.item.adapter;
 
+import java.util.Iterator;
+
 import org.springframework.batch.item.ExecutionContext;
 import org.springframework.batch.item.ItemStreamReader;
 import org.springframework.lang.NonNull;
 
-import java.util.Iterator;
-
 /**
  * A delegate for {@link ItemStreamReader} which uses {@link Iterator<T>}.
  *

spring-batch-plus/src/test/java/com/navercorp/spring/batch/plus/item/adapter/AdapterFactoryTest.java

@@ -61,6 +61,7 @@ void testItemWriter() {
 		assertThat(actual).isInstanceOf(ItemStreamWriterAdapter.class);
 	}
 
+	@SuppressWarnings({"ResultOfMethodCallIgnored", "ConstantConditions"})
 	@Test
 	void testPassingNull() {
 		assertThatThrownBy(() -> AdapterFactory.itemStreamReader(null));

spring-batch-plus/src/test/java/com/navercorp/spring/batch/plus/item/adapter/ItemProcessorAdapterTest.java

@@ -47,6 +47,7 @@ void testProcess() throws Exception {
 		assertThat(actual).isEqualTo(expected);
 	}
 
+	@SuppressWarnings({"ResultOfMethodCallIgnored", "ConstantConditions"})
 	@Test
 	void testPassingNull() {
 		// when, then

spring-batch-plus/src/test/java/com/navercorp/spring/batch/plus/item/adapter/ItemStreamReaderAdapterTest.java

@@ -110,6 +110,7 @@ void testClose() {
 		verify(itemStreamReaderDelegate, times(1)).onCloseRead();
 	}
 
+	@SuppressWarnings({"ResultOfMethodCallIgnored", "ConstantConditions"})
 	@Test
 	void testPassingNull() {
 		// when, then

spring-batch-plus/src/test/java/com/navercorp/spring/batch/plus/item/adapter/ItemStreamWriterAdapterTest.java

@@ -84,6 +84,7 @@ void testClose() {
 		verify(itemStreamWriterDelegate, times(1)).onCloseWrite();
 	}
 
+	@SuppressWarnings({"ResultOfMethodCallIgnored", "ConstantConditions"})
 	@Test
 	void testPassingNull() {
 		// when, then