Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Post-Demo] Refactor the infrastructure Terraform #187

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

aplybeah
Copy link
Contributor

@aplybeah aplybeah commented Feb 6, 2023

Ticket

https://wicmtdp.atlassian.net/browse/PRP-117

Changes

  • created network.tf
  • add additional config to the ecr repo
  • made additional resources more env-agnostic

Context for reviewers

After completing PRP-116: Migrate terraform for Eligibility Screener out of project repo and into Eligibility Screener repoREADY FOR REVIEW , we should refactor the terraform for the Eligibility Screener to use the same structure that we adopted for the PRP, based on the template repo.

Testing

When this is out of draft:

  1. Run terraform plan
  2. Plan should run successfully with no errors
  3. Run terraform apply
  4. No changes should be committed since all of the listed resources currently exist

additional testing:

  1. Log into the demo console
  2. navigate to Load Balancers
  3. use the DNS name for the load balancer to navigate to the staging version of the demo
    • expected error: Certificate not Valid -> we don't have a friendly domain name for this new load balancer that this certificate would expect.
  4. verify that other necessary resources such as security groups, etc exist in the console

@aplybeah aplybeah requested a review from rocketnova February 6, 2023 18:42
@rocketnova
Copy link
Contributor

@aplybeah I would recommend creating and deploying the entire thing from scratch in a new env to make sure everything works as expected.

@aplybeah aplybeah marked this pull request as ready for review February 8, 2023 17:23
@aplybeah aplybeah marked this pull request as draft February 8, 2023 19:01
Base automatically changed from alsia/migrate-infra to main February 16, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants