Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notifications access from service #835

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

lorenyu
Copy link
Contributor

@lorenyu lorenyu commented Jan 16, 2025

Ticket

Contributes to #792

Changes

Fix ability for ECS service to access Pinpoint:

  • Add VPC endpoints for Pinpoint services
  • Add IAM policy for accessing Pinpoint and SES to service

Also add notifications test endpoint to example app for testing:

  • Add /notifications page where you can enter an email address and get a test notification to that email address
  • Add links to the homepage to all the test pages in the example app

Context for reviewers

I added /notifications endpoint since it will be useful to test changes to notifications infrastructure, but while testing I discovered some access bugs

Testing

see navapbc/platform-test#154

@lorenyu lorenyu merged commit d22cad4 into main Jan 16, 2025
10 checks passed
@lorenyu lorenyu deleted the lorenyu/notificationstest branch January 16, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants