Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-uswds style elements from template #42

Merged
merged 5 commits into from
Oct 5, 2022

Conversation

jimmyfagan
Copy link
Contributor

Ticket

Resolves #18

Changes

These changes removed many of the custom style elements from the template. There was also a minor update to the readme file to help new users run the test script.

Context for reviewers

Details in #18; while these changes make the template look slightly less polished, the intention was to allow users of this template to use their own style elements, either from uswds or from their agency, without needing to pull out or overwrite custom style elements from the template.

Testing

Test Suites: 2 passed, 2 total
Tests:       4 passed, 4 total
Snapshots:   2 passed, 2 total
Time:        1.128 s
Ran all test suites.

Before:
Screen Shot 2022-10-04 at 5 14 47 PM

After:
Screen Shot 2022-10-04 at 5 14 26 PM

@jimmyfagan jimmyfagan marked this pull request as draft October 5, 2022 00:18
@jimmyfagan
Copy link
Contributor Author

@sawyerh Since you wrote the issue, I'm putting you on review, so you can make sure this matches what you were expecting. If we need to add somebody else to get add'l feedback about this being okay, we can do that too. Thanks!

@jimmyfagan jimmyfagan requested a review from sawyerh October 5, 2022 00:31
@jimmyfagan jimmyfagan marked this pull request as ready for review October 5, 2022 00:31
app/src/components/Layout.tsx Outdated Show resolved Hide resolved
app/styles/_uswds-theme-custom-styles.scss Outdated Show resolved Hide resolved
app/src/components/Layout.tsx Outdated Show resolved Hide resolved
app/src/components/Layout.tsx Outdated Show resolved Hide resolved
@jimmyfagan jimmyfagan force-pushed the jimmy/removeNonUSWDSStyle branch from 80f21bf to 561ad26 Compare October 5, 2022 16:11
@jimmyfagan jimmyfagan closed this Oct 5, 2022
@jimmyfagan jimmyfagan reopened this Oct 5, 2022
@jimmyfagan jimmyfagan merged commit 85a9977 into main Oct 5, 2022
@jimmyfagan jimmyfagan deleted the jimmy/removeNonUSWDSStyle branch October 5, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace custom styling with USWDS styling
2 participants