[WIP] Secrets in Nautobot Config #39
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nniehoff
requested review from
itdependsnetworks,
jathanism and
jedelman8
as code owners
jathanism
reviewed
Jul 22, 2022
| return default_value | ||
| else: | ||
| msg = f"The secret value could not be retrieved using key {err}" | ||
| raise SecretValueNotFoundError(cls, msg) from err |
There was a problem hiding this comment.
This entire module is beautiful. My only gripe is that it's duplicating patterns and/or code from the core provider source. I like where you're going with this, but is there any way we can marry these interfaces?
There was a problem hiding this comment.
I like the idea you're getting at in other words, but I don't like that it seemingly adds a lot of apparent boiler plate code, potentially complicating the introduction and maintenance of other providers.
There was a problem hiding this comment.
I'll probably re-work this entire PR but I've started the conversation to get this into Core here nautobot/nautobot#2469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really early rough draft. I wanted to see and make sure it was possible to use code from a plugin in nautobot_config.py before django was setup. I Had to abstract the idea of a connector from the provider. This allows us to have the code specific to connecting and querying a secret provider completely separate from the provider classes which are pretty heavily dependent on a
Secretobject. Please let me know high level thoughts on this before I go too much further. I am well aware that it's not pretty and there are a lot of cleanup stuff I'm really looking for more high level feedback.