Allow multiple configurations Hashicorp #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the Hashicorp Vault Secrets Provider to provide the configuration to be used per secret.
gsnider2195
reviewed
Jul 20, 2024
|
Would it make sense to make |
gsnider2195
reviewed
Jul 20, 2024
It's still only one configuration per secret. You can just support multiple configurations system wide. |
Co-authored-by: Gary Snider <[email protected]>
Instead of using "Configuration", I have switch to using "Vault" as that is closer to what is actually being chosen by the user.
gsnider2195
reviewed
Jul 22, 2024
Co-authored-by: Glenn Matthews <[email protected]>
Co-authored-by: Glenn Matthews <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67
This change allows the Hashicorp Vault Secrets Provider to provide the configuration to be used per secret.