Message Headers Improvement #1054
Conversation
| } | ||
| this.readOnly = readOnly; | ||
| if (readOnly) { | ||
| valuesMap = Collections.unmodifiableMap(tempValuesMap); |
There was a problem hiding this comment.
Collections$UnmodifiableMap throws an UnsupportedOperationException when computeIfAbsent is called which is happening in the _add method. Unsure if this is really intended
There was a problem hiding this comment.
@sdklib Are you trying to modify the headers after the message is created? This PR was intended to prevent this.
There was a problem hiding this comment.
Yup, we're using AOP to add a correlation id for proper logging across microservices to the headers.
After updating to the newest version, some unit tests fail, due to readOnly being true and the AOP Pointcut failing to add the correlation ID to the header.
The fix was easy, I was just wondering if the response should really be UnsupportedOperationException or maybe better returning a Headers.java (e.g. ReadOnlyHeaders.java) clone that doesn't have the add method in the first place. Or something similar~ :-)
There was a problem hiding this comment.
I would have to change the api to return a different object, and this would require a major version. Also, before, since I did not effectively copy the headers, the original headers object could have been modified. I'm updating the readme with a note about the change for the 2.17.2 version.
There was a problem hiding this comment.
Feared so, never the less, thank you so much! 👍
When a message is made, copy the headers and make them read only. Currently headers could be modified since they are just a reference to what the dev put in the message, but the length calculations are already done and changing headers will have a bad side effect.