(#596) Update balancer to use Placement preferred #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
reviewed
Jan 16, 2025
balancer/balancer.go
Outdated
| const SERVER_VERSION = "v2.11.0" | ||
|
|
||
| func checkServerVersion(nc *nats.Conn) error { | ||
| version := nc.ConnectedServerVersion() |
There was a problem hiding this comment.
Rather use this and look for api level 1
Line 105 in e2f9c88
We don’t know what version the meta leader is - the connection machine might be different.
API level checks talk to the machine that is jetstream leader so more reliable.
1 means 2.11
ripienaar
reviewed
Jan 16, 2025
balancer/balancer.go
Outdated
| return updated, err | ||
| } | ||
| } | ||
| if apiLvl != 1 { |
There was a problem hiding this comment.
check for < 1 as 2.12 might be level 2 etc, each time we add a major API change it would be incremented
Here we update the balancer to use the Placement api in 2.11. The balancer will now explicitly try to rebalance by setting the 'preferred' placement value to servers who lead less than the even distribution. We limit this functionality to server version 2.11.0 since preferred placement was not available before then.
|
nice one, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we update the balancer to use the Placement api in 2.11.
The balancer will now explicitly try to rebalance by setting the 'preferred' placement value to servers who lead less than the even distribution.
We limit this functionality to server version 2.11.0 since preferred placement was not available before then.