Merge pull request #621 from ripienaar/clarify_durable_name

Clarify wording around durable name and do not deprecate it
nats-io · Jan 27, 2025 · ce931af · ce931af
2 parents 6a11282 + 66ea52b
commit ce931af
Show file tree

Hide file tree

Showing 5 changed files with 55 additions and 5 deletions.
diff --git a/api/consumers.go b/api/consumers.go
@@ -527,7 +527,7 @@ type ConsumerConfig struct {
 	DeliverPolicy      DeliverPolicy   `json:"deliver_policy" yaml:"deliver_policy"`
 	DeliverSubject     string          `json:"deliver_subject,omitempty" yaml:"deliver_subject"`
 	DeliverGroup       string          `json:"deliver_group,omitempty" yaml:"deliver_group"`
-	Durable            string          `json:"durable_name,omitempty" yaml:"durable_name"` // Durable is deprecated. All consumers will have names. picked by clients.
+	Durable            string          `json:"durable_name,omitempty" yaml:"durable_name"`
 	Name               string          `json:"name,omitempty" yaml:"name"`
 	FilterSubject      string          `json:"filter_subject,omitempty" yaml:"filter_subject"`
 	FilterSubjects     []string        `json:"filter_subjects,omitempty" yaml:"filter_subjects"`

diff --git a/api/schemas_generated.go b/api/schemas_generated.go
@@ -1,4 +1,4 @@
-// auto generated 2024-11-07 11:11:35.549364 +0100 CET m=+0.015695959
+// auto generated 2025-01-27 14:32:29.163211 +0100 CET m=+0.010693459
 
 package api
 

diff --git a/schema_source/jetstream/api/v1/consumer_create_request.json b/schema_source/jetstream/api/v1/consumer_create_request.json
@@ -1,7 +1,7 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
   "$id": "https://nats.io/schemas/jetstream/api/v1/consumer_create_request.json",
-  "description": "A request to the JetStream $JS.API.CONSUMER.CREATE and $JS.API.CONSUMER.DURABLE.CREATE APIs",
+  "description": "A request to the JetStream $JS.API.CONSUMER.CREATE API",
   "title": "io.nats.jetstream.api.v1.consumer_create_request",
   "type": "object",
   "required": [

diff --git a/schemas/jetstream/api/v1/consumer_create_request.json b/schemas/jetstream/api/v1/consumer_create_request.json
@@ -1,7 +1,7 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
   "$id": "https://nats.io/schemas/jetstream/api/v1/consumer_create_request.json",
-  "description": "A request to the JetStream $JS.API.CONSUMER.CREATE and $JS.API.CONSUMER.DURABLE.CREATE APIs",
+  "description": "A request to the JetStream $JS.API.CONSUMER.CREATE API",
   "title": "io.nats.jetstream.api.v1.consumer_create_request",
   "type": "object",
   "required": [

diff --git a/schemas/server/errors.json b/schemas/server/errors.json
@@ -833,7 +833,7 @@
     "constant": "JSConsumerPullRequiresAckErr",
     "code": 400,
     "error_code": 10084,
-    "description": "consumer in pull mode requires ack policy on workqueue stream",
+    "description": "consumer in pull mode requires explicit ack policy on workqueue stream",
     "comment": "",
     "help": "",
     "url": "",
@@ -1598,5 +1598,55 @@
     "help": "",
     "url": "",
     "deprecates": ""
+  },
+  {
+    "constant": "JSConsumerInvalidGroupNameErr",
+    "code": 400,
+    "error_code": 10162,
+    "description": "Valid priority group name must match A-Z, a-z, 0-9, -_/=)+ and may not exceed 16 characters",
+    "comment": "",
+    "help": "",
+    "url": "",
+    "deprecates": ""
+  },
+  {
+    "constant": "JSStreamExpectedLastSeqPerSubjectNotReady",
+    "code": 503,
+    "error_code": 10163,
+    "description": "expected last sequence per subject temporarily unavailable",
+    "comment": "",
+    "help": "",
+    "url": "",
+    "deprecates": ""
+  },
+  {
+    "constant": "JSStreamWrongLastSequenceConstantErr",
+    "code": 400,
+    "error_code": 10164,
+    "description": "wrong last sequence",
+    "comment": "",
+    "help": "",
+    "url": "",
+    "deprecates": ""
+  },
+  {
+    "constant": "JSMessageTTLInvalidErr",
+    "code": 400,
+    "error_code": 10165,
+    "description": "invalid per-message TTL",
+    "comment": "",
+    "help": "",
+    "url": "",
+    "deprecates": ""
+  },
+  {
+    "constant": "JSMessageTTLDisabledErr",
+    "code": 400,
+    "error_code": 10166,
+    "description": "per-message TTL is disabled",
+    "comment": "",
+    "help": "",
+    "url": "",
+    "deprecates": ""
   }
 ]