Add support for single item feeds #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this library does not include any items in the items array if the originating RSS feed only has 1 item.
This is due to an inconsistency in the output of xml2json so I guess it could be argued this needs fixing upstream, but the fact remains that the code here relies on
channel.itembeing an Array of Objects, which it is not when the source XML only contains a singleitemwithinchannel. In this edge case, the content ofchannel.itemis a literal Object by itself.This leads the if statement on line 85 to fail as objects don't have a length property, and so the entire block is skipped over. Even if the if statement passed, everything within the block still relies on
itemsbeing an Array.I think my proposed changes should fix the issue.
Please let me know if you need something from me to be able accept this PR.