Isaac13 qol fixes + release 0.2.8 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrowne15
reviewed
Mar 29, 2024
| @@ -571,6 +576,8 @@ class InspectionNode : public ff_util::FreeFlyerNodelet { | |||
| if (flashlight_intensity_current_ != cfg_.Get<double>("toggle_flashlight")) { | |||
| flashlight_intensity_current_ = cfg_.Get<double>("toggle_flashlight"); | |||
| Flashlight(flashlight_intensity_current_); | |||
| sci_cam_req_ = 1; | |||
| SendPicture(-1); | |||
There was a problem hiding this comment.
Thank you! This will save the sci cam from taking extra images!
kbrowne15
approved these changes
Mar 29, 2024
bcoltin
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'm joining the release PR with the updates PR because I wanted to make new debians and do lab testing with those.
Scicam updates: don't change the focus in between takes if it's using the same value; change focus at start of the panorama and geometry surveys
Survey manager: fixed a berth1/berth2 name collision bug; make output more readable (still not great); made the monitors exit somewhat cleanly (ctrl+c and then it will ask you to press enter, once you do it will exit)
Lab testing: I tested all the new features on the lab, did a full granite lab survey, inspection, panorama, geometry