Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAS-2180: Update the HyBIG service invocation parameter. #602

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

flamingbear
Copy link
Member

@flamingbear flamingbear commented Jun 26, 2024

This is for v2.0.0 of HyBIG where image generation library is [mostly] separate from the harmony service code.

Jira Issue ID

DAS-2180

Description

As part of separating business logic from harmony service logic, the calling parameter for the service has changed in HyBIG.

This change will require harmony redeployments each time HyBIG v2 is promoted.

Local Test Steps

Pull the HyBIG branch for v2, build and test the local HyBIG image.
Branch: https://github.com/nasa/harmony-browse-image-generator/tree/mhs/DAS-2180/extract-lib
PR: nasa/harmony-browse-image-generator#28

Pull this branch and build Harmony.
(I don't know exactly how to make sure this is picked up, so I would do a full rebuild of this branch and a bootstrap of Harmony-In-A-Box.)

Ensure you don't have any .env file that overrides HYBIG_INVOCATION_ARGS.

Run the HyBIG harmony regression tests against your local Harmony-In-A-Box to ensure the service is being invoked correctly.

PR Acceptance Checklist

  • [N/A] Acceptance criteria met
  • [N/A] Tests added/updated (if needed) and passing
  • [N/A] Documentation updated (if needed)

This is for v2.0.0 of HyBIG where image generation library is [mostly] separate
from the harmony service code.
entry only made sense with respect to Docker.
@flamingbear flamingbear force-pushed the mhs/DAS-2180/hybig-as-a-library branch from 06d0ff9 to 7052aa5 Compare July 23, 2024 17:02
@flamingbear
Copy link
Member Author

It's been a minute since Harmony-In-A-Box tests have passed, and they take forever, fix or nix?

Copy link
Member

@owenlittlejohns owenlittlejohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this branch with the updated version of HyBIG and it all worked nicely.

I think the one missing thing is updating the ENV_CHANGELOG.md, to track these changes. (Sorry for the nit)

Copy link
Member

@owenlittlejohns owenlittlejohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update!

@flamingbear flamingbear marked this pull request as ready for review August 1, 2024 20:08
@indiejames indiejames self-requested a review August 1, 2024 20:31
@flamingbear flamingbear merged commit 7c5798d into main Aug 1, 2024
5 of 6 checks passed
@flamingbear flamingbear deleted the mhs/DAS-2180/hybig-as-a-library branch August 1, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants