Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAS-2031: Update regression tests with new images and metadata. #77

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

flamingbear
Copy link
Member

Description

Updates the reference image to align with the changes from DAS-2031.

You should be able to see the updated images are visually similar.

Jira Issue ID

DAS-2031

Local Test Steps

Ensure your local harmony in a box is running the correct PR for DAS-2031

Build a conda env with the info in test/hybig/environment.yaml run jupiter notebook`
edit the first cell to point to your local harmony.

Verify that all the regression tests pass.

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

@flamingbear flamingbear marked this pull request as ready for review November 6, 2023 19:02
Copy link
Member

@owenlittlejohns owenlittlejohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the notebook against my Harmony-in-a-Box instance using the DAS-2031 changes and everything looked good to me! Nice.

test/hybig/HyBIG_Regression.ipynb Show resolved Hide resolved
@flamingbear flamingbear merged commit 59fa336 into main Nov 8, 2023
@flamingbear flamingbear deleted the mhs/DAS-2031/first-stage-memory-fixes branch November 8, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants