Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nasa/cFS#812, Update Upload Artifact Version #2631

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

arielswalker
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Fixes nasa/cFS#812

Testing performed
https://github.com/arielswalker/cFE/actions/runs/12916125161

Expected behavior changes
Functional tests workflow will not fail due to outdated upload artifacts version.

System(s) tested on
GitHub Actions

Additional context
This article, https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/, states:

"This deprecation will not impact any existing versions of GitHub Enterprise Server being used by customers."

Only the opensource workflows should be updated to use the latest version, v4. The internal workflows will fail if using v4 as seen below so it should continue to use v3.

This wiki, https://github.com/actions/upload-artifact, states:

"upload-artifact@v4+ is not currently supported on GHES yet. If you are on GHES, you must use v3."

Third party code

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Walker, MCSG TECH.

@dzbaker dzbaker added the CCB:Approved Indicates code review and approval by community CCB label Jan 23, 2025
@dzbaker dzbaker merged commit 50dd496 into nasa:main Jan 29, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACTION REQUIRED: Github Actions v4 Update
2 participants