Replace generate_samplesheet.sh with generate_samplesheet.py #155
+257
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t indexes the first element. To fix this, we can grep for all columns with 'YT:Z:' which should only capture the column that we're interested in.
|
Going to push the change for Jeff's error message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported the script over to python, tested it on the following combinations:
I also added some new exceptions, such as throwing an error if the user has s3 in their dir_path and hasn't passed the s3 flag, and thorwing an error if the user specifies single-end but has forward and reverse suffix.