-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.5.2 #115
Merged
Merged
v2.5.2 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant subsetting statement from TAXONOMY
I just worked through the readme as part of running a full-flowcell delivery on the V2 pipeline for the first time. Simon was very helpful! Here are a few README edits for places where the docs are out of date or could use more information.
…et it low, but we'll need to programatically change this
…t permission to the directory again, this was causing the current error, I just added some text to the changelog so that this could be reflected
…rams the same, so I change it so that it doesn't fail
End-to-end test suite
…t csv file, and added a test samplesheet with grouping
…rial at another one, this one works locally, the question is if it will hold up under Github Actions.
…the test only runs on pull requests so that we don't exhaust our limited number of hours.
…oving description for grouping
This version is compatible with the ec2-instances that are setup using Will's tutorial.
Adding infrastructure for S3 auto-cleaning
Fixing bug where files are saved to launch directory by moving the output to working directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From CHANGELOG:
--cut_mean_quality
and--average_qual
reduced from 25 to 20).tests/main.nf.test
.github/workflows/end-to-end.yml
test-data
. The previous test dataset intest
has been removed.ref
, along with a script inbin
to add it to an S3 bucketgrouping
variable innextflow.config
matches the input samplesheet, if it doesn't, the code throws an error.resources.config
, removing hardcoded CPU/memory valuesindex-params.json
toparams-index.json
to avoid clash with Github Actions