Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.5.2 #115

Merged
merged 89 commits into from
Nov 27, 2024
Merged

v2.5.2 #115

merged 89 commits into from
Nov 27, 2024

Conversation

willbradshaw
Copy link
Contributor

From CHANGELOG:

  • Changes to default read filtering:
    • Relaxed FASTP quality filtering (--cut_mean_quality and --average_qual reduced from 25 to 20).
    • Relaxed BBDUK viral filtering (switched from 3 21-mers to 1 24-mer).
  • Overhauled BLAST validation functionality:
    • BLAST now runs on forward and reverse reads independently
    • BLAST output filtering no longer assumes specific filename suffixes
    • Paired BLAST output includes more information
    • RUN_VALIDATION can now directly take in FASTA files instead of a virus read DB
    • Fixed issues with publishing BLAST output under new Nextflow version
  • Implemented nf-test for end-to-end testing of pipeline functionality
    • Implemented test suite in tests/main.nf.test
    • Reconfigured INDEX workflow to enable generation of miniature index directories for testing
    • Added Github Actions workflow in .github/workflows/end-to-end.yml
    • Pull requests will now fail if any of INDEX, RUN, or RUN_VALIDATION crashes when run on test data.
    • Generated first version of new, curated test dataset for testing RUN workflow. Samplesheet and config file are available in test-data. The previous test dataset in test has been removed.
  • Implemented S3 auto-cleanup:
    • Added tags to published files to facilitate S3 auto-cleanup
    • Added S3 lifecycle configuration file to ref, along with a script in bin to add it to an S3 bucket
  • Minor changes
    • Added logic to check if grouping variable in nextflow.config matches the input samplesheet, if it doesn't, the code throws an error.
    • Externalized resource specifications to resources.config, removing hardcoded CPU/memory values
    • Renamed index-params.json to params-index.json to avoid clash with Github Actions
    • Removed redundant subsetting statement from TAXONOMY workflow.
    • Added --group_across_illumina_lanes option to generate_samplesheet

willbradshaw and others added 30 commits November 15, 2024 16:05
Removed redundant subsetting statement from TAXONOMY
I just worked through the readme as part of running a full-flowcell delivery on the V2 pipeline for the first time.  Simon was very helpful!  Here are a few README edits for places where the docs are out of date or could use more information.
…et it low, but we'll need to programatically change this
harmonbhasin and others added 28 commits November 25, 2024 17:52
…t permission to the directory again, this was causing the current error, I just added some text to the changelog so that this could be reflected
…rams the same, so I change it so that it doesn't fail
…t csv file, and added a test samplesheet with grouping
…rial at another one, this one works locally, the question is if it will hold up under Github Actions.
…the test only runs on pull requests so that we don't exhaust our limited number of hours.
This version is compatible with the ec2-instances that are setup using Will's tutorial.
Adding infrastructure for S3 auto-cleaning
Fixing bug where files are saved to launch directory by moving the output to working directory
@willbradshaw willbradshaw merged commit b75ddc6 into master Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants