Fix testing of notebooks on CI (for SGE exclusively) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
force-pushed
the
fix_testing_sge_ci
branch
3 times, most recently
from
0a1ea7c to
87f6b0f
Compare
Simply call `python setup.py test` through the entrypoint scripts. This works as intended in the `nanshe/nashe:sge` build's tests. So should also work here for the same intended purpose.
jakirkham
force-pushed
the
fix_testing_sge_ci
branch
3 times, most recently
from
a0dfc87 to
77774e1
Compare
jakirkham
changed the title
|
It looks due to some setup issues this has the side affect of not running the Python 2 tests. However as those don't correctly run under Python 2 anyways, this just seems like something to fix along with issue ( #4 ). So will ignore this problem for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
Tries to make some changes to the testing procedure to fix testing of the notebooks on SGE.