Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: use common canonify at request parse time #2082

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Jan 12, 2025

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

@gdamore gdamore force-pushed the http-server-canonify branch from 5851296 to 169166a Compare January 12, 2025 17:25
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.57%. Comparing base (4f44506) to head (169166a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/supplemental/http/http_server.c 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2082      +/-   ##
==========================================
- Coverage   83.63%   83.57%   -0.06%     
==========================================
  Files          93       93              
  Lines       23543    23501      -42     
  Branches     3044     3035       -9     
==========================================
- Hits        19691    19642      -49     
- Misses       3774     3783       +9     
+ Partials       78       76       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 169166a into main Jan 12, 2025
34 of 36 checks passed
@gdamore gdamore deleted the http-server-canonify branch January 12, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant