Http conn req res inline #2074
Merged
Http conn req res inline #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step towards simplifying this API and ultimately simplifying the HTTP callback API used for the server side.
gdamore
force-pushed
the
http-conn-req-res-inline
branch
from
552943d to
2ff83eb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2074 +/- ##
==========================================
- Coverage 82.99% 82.94% -0.05%
==========================================
Files 94 94
Lines 23698 23694 -4
Branches 3054 3052 -2
==========================================
- Hits 19669 19654 -15
- Misses 3949 3959 +10
- Partials 80 81 +1 ☔ View full report in Codecov by Sentry. |
gdamore
force-pushed
the
http-conn-req-res-inline
branch
from
126984c to
902bd0f
Compare
This simplified API lets callbacks obtain the response from the connection objection directly, and does not require the aio to carry it as a parameter. Further, the request and response are both stored inline in the connection, reducing allocations. This is at present only for the server; the client will get a similar set of changes.
gdamore
force-pushed
the
http-conn-req-res-inline
branch
from
902bd0f to
f42d0c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #
Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.