Nuke compat headers #2067
Merged
Nuke compat headers #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was occasionally causing "sigabrt" and similar failures in the tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2067 +/- ##
==========================================
+ Coverage 82.90% 82.99% +0.09%
==========================================
Files 95 95
Lines 23719 23719
Branches 3064 3064
==========================================
+ Hits 19664 19686 +22
+ Misses 3979 3956 -23
- Partials 76 77 +1 ☔ View full report in Codecov by Sentry. |
This will ensure that we fast fail if a test cannot complete, rather than muddling on and reporting failures elsewhere.
gdamore
force-pushed
the
nuke-compat-headers
branch
from
bcbe62d to
8967823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #
Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.