Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No recvmsg sendmsg #2032

Merged
merged 4 commits into from
Dec 30, 2024
Merged

No recvmsg sendmsg #2032

merged 4 commits into from
Dec 30, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 30, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.71%. Comparing base (60ff324) to head (9b42f5c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/platform/posix/posix_udp.c 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
+ Coverage   82.62%   82.71%   +0.08%     
==========================================
  Files          95       95              
  Lines       23656    23650       -6     
  Branches     3044     3040       -4     
==========================================
+ Hits        19546    19561      +15     
+ Misses       4036     4017      -19     
+ Partials       74       72       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This includes checks to determine if those functions are present,
and a test case to verify that scatter gather with UDP works.
This will be slower, as each vector element has to be sent in a single
system call, but for platforms that lack sendmsg it will at least work.
@gdamore gdamore merged commit 9b42f5c into main Dec 30, 2024
35 of 36 checks passed
@gdamore gdamore deleted the no-recvmsg-sendmsg branch December 31, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant