-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add use-scroll hook #102
Conversation
WalkthroughThe codebase has been updated to include a new Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (4)
- apps/playground/src/stories/hooks/useScroll.stories.tsx (1 hunks)
- packages/react-hooks/index.ts (1 hunks)
- packages/react-hooks/use-scroll/index.ts (1 hunks)
- packages/react-hooks/use-scroll/useScroll.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/react-hooks/use-scroll/index.ts
Additional comments: 6
packages/react-hooks/index.ts (1)
- 17-17: The export statement for
use-scroll
is correctly added and follows the existing pattern of export statements in the file.packages/react-hooks/use-scroll/useScroll.ts (3)
- 3-5: The
UseScrollParams
type is correctly defined with anelementRef
of typeReact.RefObject<HTMLElement>
.- 7-12: The
ScrollDirections
enum is correctly defined with appropriate direction values.- 14-42: The
useScroll
function is well-implemented, usinguseCallback
for performance optimization and handling the scrolling logic as expected.apps/playground/src/stories/hooks/useScroll.stories.tsx (2)
- 11-33: The
Box
component is correctly implemented usingforwardRef
to pass a ref to the div element.- 35-71: The
Example
component effectively demonstrates the usage of theuseScroll
hook with a well-structured example and appropriate event handlers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one comment, the rest looks great! thanks for this PR!
elementRef: React.RefObject<HTMLElement>; | ||
}; | ||
|
||
export enum ScrollDirections { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you change this type to use sum types instead of enums? Enums are less recommended in TS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes were added. Please review 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/react-hooks/use-scroll/useScroll.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/react-hooks/use-scroll/useScroll.ts
What's this PR do?
This PR adds the use-scroll hook which, given a reference to an element, can scroll the element when it is in overflow.
@ulises-jeremias @rpmolina
Summary by CodeRabbit
useScroll
hook for smooth scrolling functionality in React components.Example
component showcasing the use of theuseScroll
hook with interactive elements.