make docker work #168
Merged
make docker work #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously the dockerfile installed the dependencies and you then would mount the source folder into the container, shadowing the just created node_modules folder. So this setup only works if you had a node_modules folder on the host machine already which was kind of the reason to use docker in first place. To make this work, install the app into a subfolder and create the node_modules on folder up. Adopted some example files from here: - https://github.com/BretFisher/node-docker-good-defaults Also added a Makefile :-) So you can just do a 'make docker-server' or 'make docker-build'.
sni
force-pushed
the
rework_dockerfile
branch
from
673b30f to
434acea
Compare
|
Awesome, much better than my current hacky setup! Just a few minor details I would address:
If you prefer, I can also merge this and adjust this. |
|
there you go... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously the dockerfile installed the dependencies and you then would mount the source folder into the container, shadowing the just created node_modules folder. So this setup only works if you had a node_modules folder on the host machine already which was kind of the reason to use docker in first place.
To make this work, install the app into a subfolder and create the node_modules on folder up.
Adopted some example files from here:
Also added a Makefile :-)
So you can just do a 'make docker-server' or 'make docker-build'.