Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nacos_grpc_service.proto #783

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

yanxyc
Copy link
Contributor

@yanxyc yanxyc commented Nov 7, 2024

need go_package to void conflict, maybe need regenerate .pb.go file

panic: proto: file "nacos_grpc_service.proto" has a name conflict over Request
See https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin0325 binbin0325 merged commit b098c04 into nacos-group:master Jan 21, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants