Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug fix] fix up encryption logger: replace logging when init() with createConfigClient #689

Closed

Conversation

robynron
Copy link
Contributor

@robynron robynron commented Dec 1, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (28188c7) 29.65% compared to head (15bede6) 28.91%.
Report is 2 commits behind head on master.

❗ Current head 15bede6 differs from pull request most recent head a5e22e0. Consider uploading reports for the commit a5e22e0 to get more accurate results

Files Patch % Lines
common/nacos_server/nacos_server.go 33.33% 4 Missing ⚠️
clients/config_client/config_client.go 0.00% 2 Missing ⚠️
clients/naming_client/naming_proxy_delegate.go 77.77% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
- Coverage   29.65%   28.91%   -0.74%     
==========================================
  Files          40       40              
  Lines        3136     3147      +11     
==========================================
- Hits          930      910      -20     
- Misses       2136     2166      +30     
- Partials       70       71       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robynron robynron closed this Dec 1, 2023
@robynron robynron deleted the dev/chasu/fixup_logger_level branch December 15, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants